Fix shutdown of test server#1560
Merged
Merged
Conversation
juergbi
requested review from
BenjaminSchubert,
cs-shadow and
gtristan
as code owners
BenjaminSchubert
approved these changes
Jan 13, 2022
Contributor
BenjaminSchubert
left a comment
BenjaminSchubert
left a comment
There was a problem hiding this comment.
Seems good, thanks
This is required to pass the assertion in `CASDChannel.close()`:
assert self._shutdown_requested, "Please request shutdown before closing"
buildbox-casd processes used by test servers were not terminated and kept running after the end of the tests (or crashed because the test deleted the directories used by buildbox-casd).
juergbi
force-pushed
the
juerg/tests-casd-server-shutdown
branch
from
81621f6 to
3a3413d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildbox-casd processes used by test servers were not terminated and kept running after the end of the tests (or crashed because the test deleted the directories used by buildbox-casd).