Allow artifact names in bst shell#1719
Merged
Merged
Conversation
gtristan
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
juergbi
as code owners
Contributor
Author
|
I've added some more testing to this branch (locally), as I was trying to see what happens when you try But I encountered: This is correct because we don't encode runtime dependencies into artifacts (which necessary by design), so I conclude that we cannot support shelling into artifact names except for when running build shells. I will add a more convenient user facing error in the case the user has attempted to launch a shell on an artifact name without specifying |
Contributor
Author
|
Updated, added a new test to ensure the correct error messaging when the user tries to use |
gtristan
changed the title
ghost
approved these changes
Aug 16, 2022
gtristan
force-pushed
the
tristan/shell-artifacts
branch
2 times, most recently
from
8ba4115 to
fa45e59
Compare
Now that we cache the full sandbox root for failed builds we can debug builds directly on downloaded artifacts. Fixes #1711
This will enable bash completions on artifact names for `bst shell`
… bst shell Ensure we get a comprehensive message when the user tries to use `bst shell` on an artifact name for anything other than shelling into a cached build tree.
gtristan
force-pushed
the
tristan/shell-artifacts
branch
from
fa45e59 to
d2cd5bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we cache the full tree when builds fail, it becomes more interesting to have a buildshell on a failed artifact without needing to reproduce the project data.
Fixes #1711