Skip to content

requirements.txt: Bump grpc version to be compatible with Python 3.11#1807

Closed
cs-shadow wants to merge 1 commit intomasterfrom
chandan/update-pinned-deps
Closed

requirements.txt: Bump grpc version to be compatible with Python 3.11#1807
cs-shadow wants to merge 1 commit intomasterfrom
chandan/update-pinned-deps

Conversation

@cs-shadow
Copy link
Member

missed this in #1806

@cs-shadow
Copy link
Member Author

seems like our testsuite is busted with the new version of grpc, draft for now

@nanonyme
Copy link
Contributor

Yeah, there's similarly issues with bst1. In there it looked there was some general timeout in asyncio reactor getting hit with timeout of 30 minutes per test.

@nanonyme
Copy link
Contributor

nanonyme commented Dec 29, 2022

As per one of the CI runs that actually exited, it looks like there's leftover grpcio threads from tests. We're not running bst like normal (launch bst as a subprocess) but instead running bst main function inside pytest. This leaks grpcio into pytest test runner which can result in all kinds of trouble if it doesn't properly terminate. (but which real users of BuildStream can never encounter) I tried refactoring earlier the setup to instead call bst through subprocess but it turned out we have some exception analysis in tests that is impossible to do if you aren't in same process as bst.

@juergbi
Copy link
Contributor

juergbi commented Jan 21, 2023

Replaced by #1815, which fixes the tests.

@juergbi juergbi closed this Jan 21, 2023
@cs-shadow cs-shadow deleted the chandan/update-pinned-deps branch February 6, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants