cascache.py: Use UploadTree with storage-service, if available#1966
Merged
cascache.py: Use UploadTree with storage-service, if available#1966
UploadTree with storage-service, if available#1966Conversation
It was always set to `True`.
Cache query is currently relatively slow when `storage-service` is enabled as the tree traversals are handled by Python code. Calling `UploadTree` moves that logic to buildbox-casd, which is significantly faster.
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
abderrahim
approved these changes
Nov 3, 2024
Contributor
|
Is this the last missing piece of #1042? Or is there more to it? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache query is currently relatively slow when
storage-serviceis enabled as the tree traversals are handled by Python code. CallingUploadTreemoves that logic to buildbox-casd, which is significantly faster.In local tests I've seen a 2-4x improvement of the cache query speed.
The corresponding buildbox-casd change is pending in https://gitlab.com/BuildGrid/buildbox/buildbox/-/merge_requests/757. The current code is kept as fallback path, i.e., current/older versions of buildbox-casd continue to be supported, without the optimization.