Support directory mtime to fix tests with recent buildbox-casd#2001
Support directory mtime to fix tests with recent buildbox-casd#2001
Conversation
This fixes test failures with recent versions of buildbox-casd, see
commit 85f0578f ("common: Support capturing directory mtime and mode").
|
This changes the artifact content correct ? Building a given artifact before this fix and after this fix, for the same cache key, will give you a different cas digest correct ? Or, does this avoid buildstream automatically consuming this new behaviour from buildbox-casd ? So users who have not yet applied this patch but happen to have a newer buildbox-casd, will be producing different artifacts by default ? |
|
For workspace builds, the buildbox-casd change will result in a different CAS digest as directory mtimes are now captured as well. However, CAS digests of workspace builds are not deterministic anyway due to the file timestamps. What this change does is to apply the directory mtimes captured by recent casd to directories in And it fixes a test to work with old and new versions of buildbox-casd. |
This fixes test failures with recent versions of buildbox-casd, see commit 85f0578f ("common: Support capturing directory mtime and mode").