Fixes some otel and nested burr application bugs#590
Merged
Conversation
This was caught trying to run nested burr with otel.
|
A preview of bf2b632 is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/590 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
|
|
||
| def test_burr_tracking_span_processor_on_end_with_none_tracker(): | ||
| """Test that on_end handles None tracker gracefully without raising an error.""" | ||
| processor = BurrTrackingSpanProcessor() |
Contributor
There was a problem hiding this comment.
Are we sure we need all this mocking? IIRC I wrote this to be easier to unit test...
elijahbenizzy
approved these changes
Nov 10, 2025
Important that mocks use `spec=` where possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was caught trying to run nested burr with otel.
Changes
How I tested this
Notes
Checklist