[CALCITE-2333] Stop releasing zips#51
Merged
asfgit merged 2 commits intoapache:masterfrom May 30, 2018
Merged
Conversation
Member
|
Looks like the first commit shouldn't really be in the PR, but LGTM. Although couldn't hurt to have someone more familiar with Avatica do a review as well. |
Member
Author
|
I've moved the first commit to master (it's really trivial), but it's still showing in the PR for some reason. Pinging @joshelser for a second look. |
Member
|
Yeah, I'm not really concerned about the other commit. Seems like a bug in GitHub that it hasn't gone away. |
Member
|
Looks fine to me. Proof would be in the pudding as they say (would suggest you just run a 'mock' release process for both and verify what shows up in the staged Maven repository on https://repository.apache.org, dropping the staged repo after). |
Member
Author
|
Thanks, Josh. I'll give that a shot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the website and maven configs to stop releasing zips for future releases.
The site was tested locally and works fine.
Can someone verify that I have updated the pom.xml files correctly?