[CALCITE-2594] Ensure forbiddenapis and maven-compiler use the correct JDK version#74
Merged
asfgit merged 1 commit intoapache:masterfrom Sep 25, 2018
Merged
Conversation
joshelser
reviewed
Sep 25, 2018
pom.xml
Outdated
| <configuration> | ||
| <source>8</source> | ||
| <target>8</target> | ||
| <source>${maven.compiler.source}</source> |
Member
There was a problem hiding this comment.
I think these are superfluous when you have maven.compiler.source and maven.compiler.target set as you do.
Contributor
Author
There was a problem hiding this comment.
Yea I think so too. I just wanted to be sure we set the same version in one spot. Afraid someone comes along later and updates the 8 to a 9/10/11 and doesn't change the maven.compiler.source/maven.compiler.target properties.
Member
There was a problem hiding this comment.
Maybe drop them here, and leave a comment not to re-add?
Contributor
Author
There was a problem hiding this comment.
Yup that works. I'll make that change.
…t JDK version Close apache#74 Signed-off-by: Kevin Risden <krisden@apache.org>
risdenk
force-pushed
the
CALCITE-2594
branch
from
b5b7c30 to
8db4bc1
Compare
joshelser
approved these changes
Sep 25, 2018
Contributor
Author
|
Thanks for the review @joshelser! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.