[CALCITE-2939] NPE when executeBatch array type.#94
Merged
F21 merged 2 commits intoapache:masterfrom Apr 23, 2019
Merged
Conversation
danny0405
reviewed
Apr 12, 2019
| } | ||
| if (componentRep == null && list.size() > 0) { | ||
| componentRep = ((TypedValue) list.get(0)).type; | ||
| } |
Contributor
There was a problem hiding this comment.
The document already say that the componentType in TypedValue is a non-null value [1], the only way is that when the nested parse in [2], which is a null we passed in initiatively. For null i think it is reasonable cause we do not know what the value component type yet. The code you patched is reasonable if we finally got the list element type.
[1]
[2]
danny0405
reviewed
Apr 12, 2019
| } | ||
| } | ||
| if (componentRep == null && list.size() > 0) { | ||
| componentRep = ((TypedValue) list.get(0)).type; |
Contributor
There was a problem hiding this comment.
If we still can not got the type, we should throw an exception, can you please add a check here ?
Member
|
@danny0405 Can you look at the updated changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.