Add type information to RexLiteral#digest, ensure planner uses just RelNode#digest for identity#1002
Closed
vlsi wants to merge 1 commit intoapache:masterfrom
Closed
Add type information to RexLiteral#digest, ensure planner uses just RelNode#digest for identity#1002vlsi wants to merge 1 commit intoapache:masterfrom
vlsi wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Unfortunately, it adds types to each and every value for I wonder if we can add special "digest without type" for Values puposes (it can print types just once) On the other hand, null expressions become easier to understand: |
ae54d51 to
d496906
Compare
vlsi
commented
Jan 13, 2019
| case COERCIBLE: | ||
| switch (coercibility2) { | ||
| case COERCIBLE: | ||
| return new SqlCollation( |
Contributor
Author
There was a problem hiding this comment.
@julianhyde , I don't quite get new SqlCollation thing here, however it looks like new here makes no difference. It might be SqlCollation#strength should be updated as well, however it does not seem to be supported in Calcite yet.
This change was required so SqlCollation.IMPLICIT singleton is propagated across all expressions.
ba17d23 to
d3166e7
Compare
…ner uses just RelNode#digest for identity fixes apache#1002
bf3bcc9 to
b56cb1b
Compare
jszeluga
pushed a commit
to jszeluga/calcite
that referenced
this pull request
Feb 18, 2019
…case the type of 1 is int in the first rel and long in the second one Add type information to RexLiteral#digest, ensure planner uses just RelNode#digest for identity fixes apache#1002
zhztheplayer
pushed a commit
to zhztheplayer/calcite
that referenced
this pull request
Feb 20, 2019
…case the type of 1 is int in the first rel and long in the second one Add type information to RexLiteral#digest, ensure planner uses just RelNode#digest for identity fixes apache#1002
chadasa
pushed a commit
to chadasa/calcite
that referenced
this pull request
Feb 27, 2019
…case the type of 1 is int in the first rel and long in the second one Add type information to RexLiteral#digest, ensure planner uses just RelNode#digest for identity fixes apache#1002
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…case the type of 1 is int in the first rel and long in the second one Add type information to RexLiteral#digest, ensure planner uses just RelNode#digest for identity fixes apache#1002
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
…case the type of 1 is int in the first rel and long in the second one Add type information to RexLiteral#digest, ensure planner uses just RelNode#digest for identity fixes apache#1002 Change-Id: I00ff6e0d6aed08d1beecb85e4508444db6e15248
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.