[CALCITE-2208]Schemas now uses the config of current connection to make context,#1123
Closed
LaiZhou wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-2208]Schemas now uses the config of current connection to make context,#1123LaiZhou wants to merge 1 commit intoapache:masterfrom
LaiZhou wants to merge 1 commit intoapache:masterfrom
Conversation
and CalcitePrepareImpl's method `parser_` now uses the context's config rather than a default config to create a SqlParser (Lai Zhou)
LaiZhou
changed the title
Contributor
|
@LaiZhou Why did you close this? Let's discuss in https://issues.apache.org/jira/browse/CALCITE-2208. |
Contributor
Author
|
@julianhyde , I try to fix this bug, but my PR is quick and dirty, only works for my use case , so I closed this. It will cause problems when I use SqlCreateTable. I'll take more time to dig the related code to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schemas now uses the config of current connection to make context,
and CalcitePrepareImpl now uses the context's config rather than a default config
to create a SqlParser in the 'parse_' method.