[CALCITE-2992] Enhance implicit conversions when generating hash join keys for an equiCondition#1158
Open
LaiZhou wants to merge 3 commits intoapache:mainfrom
Open
[CALCITE-2992] Enhance implicit conversions when generating hash join keys for an equiCondition#1158LaiZhou wants to merge 3 commits intoapache:mainfrom
LaiZhou wants to merge 3 commits intoapache:mainfrom
Conversation
…ys for an equiCondition (Lai Zhou)
chunweilei
reviewed
Apr 13, 2019
| list.add(fieldReference(v1, field)); | ||
| list.add( | ||
| Expressions.call(CONVERT2STRING_METHOD, fieldReference(v1, field))); | ||
| } |
Contributor
There was a problem hiding this comment.
Need test case at least. Besides, I really don't think it's a good idea to convert join keys to strings considering its costs.
Contributor
Author
There was a problem hiding this comment.
@chunweilei ，I pushed a new commit , would you review it?
…enhance the implicit conversions when generating hash join keys(Lai Zhou)
LaiZhou
changed the title
danny0405
force-pushed
the
master
branch
2 times, most recently
from
80f411d to
ca27fe9
Compare
vlsi
force-pushed
the
master
branch
2 times, most recently
from
49cb002 to
8768a23
Compare
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ys for an equiCondition (Lai Zhou)
Make implicit conversions when generating hash join keys for an equiCondition.
CALCITE-2992