Skip to content

[CALCITE-3009] Duplicate key is not detected in xml answer file#1167

Closed
chunweilei wants to merge 2 commits intoapache:masterfrom
chunweilei:fail_when_finding_duplicate_keys
Closed

[CALCITE-3009] Duplicate key is not detected in xml answer file#1167
chunweilei wants to merge 2 commits intoapache:masterfrom
chunweilei:fail_when_finding_duplicate_keys

Conversation

@chunweilei
Copy link
Contributor

@chunweilei chunweilei commented Apr 17, 2019

<Resource name="sql">
<![CDATA[select t1.name, t2.ename
from DEPT_NESTED as t1,
unnest(t1.employees) as t2]]>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunweilei
Copy link
Contributor Author

@julianhyde could you please review this PR? Appreciate it.

@chunweilei chunweilei force-pushed the fail_when_finding_duplicate_keys branch from 4b0c30f to e0107d5 Compare April 19, 2019 06:09
@chunweilei chunweilei force-pushed the fail_when_finding_duplicate_keys branch from e0107d5 to fc9f0c6 Compare April 19, 2019 06:13
@chunweilei
Copy link
Contributor Author

Update the PR including:

  • Add a validate method to check all test cases when loading the document
  • Change the commit message to "Duplicate test cases in the .xml file"

Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hsyuan hsyuan changed the title [CALCITE-3009] It should fail if there are duplicate keys in a .xml file [CALCITE-3009] Duplicate key is not detected in xml answer file Apr 20, 2019
@hsyuan hsyuan added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Apr 21, 2019
julianhyde added a commit to julianhyde/calcite that referenced this pull request Apr 21, 2019
@asfgit asfgit closed this in ee83efd Apr 21, 2019
wangxlong pushed a commit to wangxlong/calcite that referenced this pull request Feb 13, 2020
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Aug 28, 2025
…es not contain duplicate test names

Close apache#1167

Change-Id: I44c3e80fcf74c8ab41d25818ef6a2c3ebc404f22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants