Skip to content

[CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg)#1172

Closed
vineetgarg02 wants to merge 1 commit intoapache:masterfrom
vineetgarg02:CALCITE-3007
Closed

[CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg)#1172
vineetgarg02 wants to merge 1 commit intoapache:masterfrom
vineetgarg02:CALCITE-3007

Conversation

@vineetgarg02
Copy link
Contributor

No description provided.

LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
LogicalAggregate(group=[{}], m=[MAX($0)], c=[COUNT()], d=[COUNT($0)])
LogicalProject(MGR=[$3])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #1161 will fix this wrong plan, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsyuan That is correct

Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hsyuan hsyuan added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Apr 18, 2019
LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
LogicalFilter(condition=[OR(AND(>($0, $9), <>($10, 0)), AND(>($0, $9), <>($10, 0), IS NOT TRUE(>($0, $9)), <=($10, $11)))])
LogicalFilter(condition=[OR(AND(IS TRUE(>($0, $9)), <>($10, 0)), AND(>($10, $11), null, <>($10, 0), IS NOT TRUE(>($0, $9))), AND(>($0, $9), <>($10, 0), IS NOT TRUE(>($0, $9)), <=($10, $11)))])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just notice this, any idea for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsyuan This is the result of CASE simplification. With cast it looks like CASE was simplified to this. I went over this and it looks semantically correct to me.

@hsyuan hsyuan closed this in ceb3674 Apr 19, 2019
@hsyuan
Copy link
Member

hsyuan commented Apr 19, 2019

@vineetgarg02
Copy link
Contributor Author

Looks like this patch caused test failure: https://builds.apache.org/job/Calcite-Master/jdk=JDK%201.9%20(latest),label_exp=ubuntu&&!cloud-slave&&!H27/lastBuild/console

I don't know why.

That is strange. I am unable to see this failure locally. May be some environmental/configuration issue?

wangxlong pushed a commit to wangxlong/calcite that referenced this pull request Feb 13, 2020
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Jun 18, 2021
Close apache#1172

Change-Id: I9ed50a11ce3869e140c1d103b4a103e280d65403
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Mar 16, 2026
Close apache#1172

Change-Id: I9ed50a11ce3869e140c1d103b4a103e280d65403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants