[CALCITE-3013] support CeilFuncBigInt <BIGINT> TO <TIME_UNIT>#1178
Closed
xy2953396112 wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3013] support CeilFuncBigInt <BIGINT> TO <TIME_UNIT>#1178xy2953396112 wants to merge 1 commit intoapache:masterfrom
xy2953396112 wants to merge 1 commit intoapache:masterfrom
Conversation
xy2953396112
changed the title
xy2953396112
changed the title
xy2953396112
force-pushed
the
ceilForBigInt
branch
from
df0a5d1 to
8ac7cd5
Compare
Contributor
Author
|
cc @dynamix @mikehinchey @smola for review |
Contributor
|
I don't see a need for this function. The SQL standard tries hard to maintain the abstraction that datetime values are NOT just milliseconds since 1970 (and it succeeds). If you want to add a user-defined function (not in Calcite) you can do it. It you do it right it will probably optimize to a few machine instructions. Let's continue discussion at https://issues.apache.org/jira/browse/CALCITE-3013 rather than in github. |
danny0405
force-pushed
the
master
branch
2 times, most recently
from
80f411d to
ca27fe9
Compare
vlsi
force-pushed
the
master
branch
2 times, most recently
from
49cb002 to
8768a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.