Skip to content

[CALCITE-3084] Implement JDBC string functions: ASCII, REPEAT, SPACE, SOUNDEX, DIFFERENCE#1224

Merged
chunweilei merged 1 commit intoapache:masterfrom
ambition119:add_jdbcFun
May 24, 2019
Merged

[CALCITE-3084] Implement JDBC string functions: ASCII, REPEAT, SPACE, SOUNDEX, DIFFERENCE#1224
chunweilei merged 1 commit intoapache:masterfrom
ambition119:add_jdbcFun

Conversation

@ambition119
Copy link
Contributor

@ambition119 ambition119 commented May 21, 2019

Fix ISSUE #3048

Implement JDBC string functions:

{fn ASCII(string)}
{fn DIFFERENCE(string, string)}
{fn REPEAT(string, integer)}
{fn SOUNDEX(string)}
{fn SPACE(integer)}

@chunweilei
Copy link
Contributor

Thanks for raising this. I am wondering if you can file another jira for this.

@ambition119
Copy link
Contributor Author

Thanks for raising this. I am wondering if you can file another jira for this.

thanks, I can create new jira.

@ambition119 ambition119 changed the title [CALCITE-2965] Implement JDBC string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE [CALCITE-3084] Implement JDBC string functions: ASCII, REPEAT, SPACE, SOUNDEX, DIFFERENCE May 22, 2019
@chunweilei
Copy link
Contributor

Please add your id in the end of commit message like [CALCITE-3084] xxxx (you jira id).

@ambition119
Copy link
Contributor Author

Please add your id in the end of commit message like [CALCITE-3084] xxxx (you jira id).

my jira is CALCITE-3084, title info is 'Implement JDBC string functions: ASCII, REPEAT, SPACE, SOUNDEX, DIFFERENCE';

my commit message is

$ git log -2
[CALCITE-3084] Implement JDBC string functions: ASCII, REPEAT, SPACE, SOUNDEX, DIFFERENCE

Because the message is too long, so it looks like there is a middle … …, thanks.

@chunweilei
Copy link
Contributor

@ambition119 What i mean is you should add your jira id as follows:
image

@chunweilei
Copy link
Contributor

chunweilei commented May 23, 2019

You can find more about contributing in https://calcite.apache.org/develop/#contributing.

@ambition119
Copy link
Contributor Author

You can find more about contributing in https://calcite.apache.org/develop/#contributing.

oh, thanks.

Copy link
Contributor

@chunweilei chunweilei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunweilei chunweilei added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label May 24, 2019
@chunweilei chunweilei merged commit 6120ff0 into apache:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants