[CALCITE-841] In ProjectToWindowRule, RexOver will be put in the same…#124
Closed
hsuanyi wants to merge 1 commit intoapache:masterfrom
hsuanyi:CALCITE-841NEW
Closed
[CALCITE-841] In ProjectToWindowRule, RexOver will be put in the same…#124hsuanyi wants to merge 1 commit intoapache:masterfrom hsuanyi:CALCITE-841NEW
hsuanyi wants to merge 1 commit intoapache:masterfrom
hsuanyi:CALCITE-841NEW
Conversation
… cohort if the following conditions are satisfied (1). They have the same RexWindow (2). They are not dependent on each other
Contributor
|
Please don't put spaces at ends of lines: "... \n". You end up with spaces at ends of lines in RelOptRulesTest.xml, and then later there are spurious diffs when someone's IDE removes the spaces. |
Contributor
There was a problem hiding this comment.
don't you mean 'rank++'?
Contributor
|
These are all minor nits. I have fixed them and rebased and will commit when the tests pass. |
Contributor
Author
|
Thanks Julian! |
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
…pressions (Hsuan-Yi Chu) In ProjectToWindowRule, RexOver will be put in the same cohort if the following conditions are satisfied: (1). They have the same RexWindow (2). They are not dependent on each other Close apache/calcite#124
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#124) …p argument (Wang Yanlin) 1. Add map info from Java Map class to SqlTypeName.Map 2. SqlTypeName.Map is not a basic type, should not be used in factory method "createSqlType", just like SqlTypeName.Array 3. Add coerce rule for SqlTypeName.MAP Fix-up(by Danny): * Fix GeodeTable#query field type inference; * Fix GeodeUtils#convert for nested PdxInstance because in JavaTypeFactoryExtImpl#createPdxType, the nested PdxInstance is inferred as Map type(we can not describe nested JavaType correctly now). close apache#1521 Change-Id: If1449d398b20914614dc573ee15d999b24223c3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… cohort if the following conditions are satisfied
(1). They have the same RexWindow
(2). They are not dependent on each other