[CALCITE-3122] Full implementation of converting Pig Latin scripts in… #1265
Conversation
| return planner; | ||
| } | ||
|
|
||
| public void setPlanner(RelOptPlanner planner) { |
There was a problem hiding this comment.
This is a HACK to reset planner for all nodes in a logical plan. Alternative may be to use a RelShuttle to make a new plan with the desired planner. Not sure if we have a better way.
There was a problem hiding this comment.
Can you explain why we have to reset planner? Thanks!
There was a problem hiding this comment.
After initial mapping of Pig logical plan to Calcite logical plan, I need to write an optimizer rule to optimize the plan. So need to write a new planner for to optimize the plan and assign this new planner to all rel nodes in the plan.
| /** | ||
| * Extension to {@link RelBuilder} for Pig logical operators. | ||
| */ | ||
| public class LogicalPigRelBuilder extends PigRelBuilder { |
There was a problem hiding this comment.
Quick question, what is the reason to extend PigRelBuilder instead of modifying PigRelBuilder directly?
There was a problem hiding this comment.
Because I want the Pig Rel builder to be in the piglet module. We can refactor the code, merge two classes into one and save it in Piglet.
| return planner; | ||
| } | ||
|
|
||
| public void setPlanner(RelOptPlanner planner) { |
There was a problem hiding this comment.
Can you explain why we have to reset planner? Thanks!
|
Any suggestions on fixing this error. I dont have a Window machine, so could not reproduce it locally.
|
…to Calcite relational algebra and Calcite SQL (Khai Tran)
…uilder are grouped together as original code
…r conversion as much as possible
…uilder and remame LogicalPigRelBuilder to PigRelBuilder
…t comments, and fix variable name mispelling
khaitranq
force-pushed
the
pull-request-khaitran
branch
from
2ea14e3 to
2c0c3e2
Compare
…bra and Calcite SQL (Khai Tran) Fix RAT report on Travis on unapproved license files Add javadoc for SqlImplementor.resetAlias Move logic RexWindowBound.toSqlNode to SqlImplementor.Context Remove SqlNode.toSqlString and replace it with SqlNode.unparse Mute pig parser log in piglet tests Refactor DynamicTupleRecordType Log CALCITE-3193 for moving Uncollect to RelBuilder Log CALCITE-3194 for converting Pig string patterns into SQL string patterns Log CALCITE-3195 for fixing the enumerable code generator, then remove PigUDFWrapper Move ToLogicalConverter to an independent class and use RelBuilder for conversion as much as possible Refactor: remove dependency on core/PigRelBuilder from LogicalPigRelBuilder and remame LogicalPigRelBuilder to PigRelBuilder Resolve CALCITE-3193 and refactor the Pig UDF lookup code Close apache#1265
…s the PigToSqlAggregateRule being applied to produce a more optimized plan for multieset projection
…bra and Calcite SQL (Khai Tran) Remove SqlNode.toSqlString and replace it with SqlNode.unparse. Mute pig parser log in piglet tests. Refactor DynamicTupleRecordType. Remove dependency on core/PigRelBuilder from LogicalPigRelBuilder and rename LogicalPigRelBuilder to PigRelBuilder. Fix RAT report on Travis on unapproved license files. Close apache#1265
…bra and Calcite SQL (Khai Tran) Remove SqlNode.toSqlString and replace it with SqlNode.unparse. Mute pig parser log in piglet tests. Refactor DynamicTupleRecordType. Remove dependency on core/PigRelBuilder from LogicalPigRelBuilder and rename LogicalPigRelBuilder to PigRelBuilder. Fix RAT report on Travis on unapproved license files. Close apache#1265
2 participants
…to Calcite relational algebra and Calcite SQL (Khai Tran)