Skip to content

[CALCITE-3060] MutableProject should be generated based on INVERSE_SURJECTION mapping#1268

Merged
hsyuan merged 1 commit intoapache:masterfrom
DonnyZone:CALCITE-3060
Jun 29, 2019
Merged

[CALCITE-3060] MutableProject should be generated based on INVERSE_SURJECTION mapping#1268
hsyuan merged 1 commit intoapache:masterfrom
DonnyZone:CALCITE-3060

Conversation

@DonnyZone
Copy link
Copy Markdown
Contributor

As discussed in CALCITE-3060, mapping beheavior should be fixed.

Copy link
Copy Markdown
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hsyuan hsyuan added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Jun 17, 2019
Copy link
Copy Markdown
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nice catch

@hsyuan hsyuan merged commit bd42d29 into apache:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants