[CALCITE-3237] IndexOutOfBoundsException in Expression writer#1364
Closed
snallapa wants to merge 4 commits intoapache:masterfrom
Closed
[CALCITE-3237] IndexOutOfBoundsException in Expression writer#1364snallapa wants to merge 4 commits intoapache:masterfrom
snallapa wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
|
LGTM |
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…d Java code from linq4j (Sahith Nallapareddy) The problem was that ExpressionWriter was using a list of indent strings but it did not resize the list for very large indents. The solution was to use Avatica's Spacer class. Close apache#1364
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
…d Java code from linq4j (Sahith Nallapareddy) The problem was that ExpressionWriter was using a list of indent strings but it did not resize the list for very large indents. The solution was to use Avatica's Spacer class. Close apache#1364 Change-Id: If9f8705f949e8d547a32aecca48a1c0928d0a525
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpressionWriter.begin was using ArrayList.get on the Indent which has an initial capacity of 20. I ran into issues where this limit was reached and thought this should be .of which ensures the capacity