[CALCITE-3297] PigToSqlAggregateRule should be applied on multi-set projection to produce an optimal plan#1420
Closed
ihuzenko wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3297] PigToSqlAggregateRule should be applied on multi-set projection to produce an optimal plan#1420ihuzenko wants to merge 1 commit intoapache:masterfrom
ihuzenko wants to merge 1 commit intoapache:masterfrom
Conversation
…rojection to produce an optimal plan
Contributor
|
Thanks @ihuzenko ,the AppVeyor is still failing, does this patch solve the problem ? |
Member
Author
|
Hello @danny0405 , the fix enables one of Pig plan optimizations. Fails on AppVeyor is another env specific issue. |
Contributor
|
Yes, I logged https://issues.apache.org/jira/browse/CALCITE-3307 for the AppVeyor issue. |
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…rojection to produce an optimal plan (Igor Guzenko) Close apache#1420
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
…rojection to produce an optimal plan (Igor Guzenko) Close apache#1420 Change-Id: I3481e33f1e0926d70a2177624f6fa8be19fcdb73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @julianhyde , the PigToSqlAggregateRule was affected by my additional check that I added to rel builder in scope of CALCITE-3138. At that time I thought that merging restructuring project (project which collects flattened fields back into struct here ) and flattening projects added ,for example, on top of scan makes work performed by RelStructuredTypeFlattener redundant. Please look at test updates in the PR. The final expressions in projects looks really redundant for me, for example ROW($2.OTHERS.A, $2.OTHERS.B) could be simply $2.OTHERS, and other results, like flattening and collecting back results of ITEM(...) look weird.