[CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri…#1423
Merged
danny0405 merged 1 commit intoapache:masterfrom Aug 31, 2019
Merged
Conversation
hsyuan
changed the title
Member
|
Can you add the test case in the issue? |
Member
|
Sorry, just noticed the test case. :) |
…s the same during sql-to-rel conversion
hsyuan
added
the
LGTM-will-merge-soon
Member
|
Please change the commit title by adding JIRA issue. |
danny0405
force-pushed
the
CALCITE-3310
branch
from
ced4a30 to
b0b65be
Compare
Contributor
Author
|
Thanks for the reminder @hsyuan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng sql-to-rel conversion