Skip to content

[CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark#1427

Merged
zabetak merged 1 commit intoapache:masterfrom
zabetak:calcite-3314
Sep 2, 2019
Merged

[CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark#1427
zabetak merged 1 commit intoapache:masterfrom
zabetak:calcite-3314

Conversation

@zabetak
Copy link
Member

@zabetak zabetak commented Aug 30, 2019

Disable OWASP dependency-check for pig, piglet, and spark modules.

<phase>none</phase>
</execution>
</executions>
</plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it warn instead of fail the build for these modules? That would at least still show what vulnerabilities there are. In case someone wants to tackle it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think warning would be better than straight skipping. Not sure what the output would look like though and if it would be misleading

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @risdenk I guess you are right; I have another workaround, will commit shortly.

…cite-piglet, calcite-spark

Never fail the build due to OWASP dependency-check for pig, piglet, and spark modules.
@zabetak zabetak merged commit c9520c3 into apache:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants