[CALCITE-3316] Exception while deserializing LogicalCorrelate from json string#1433
Merged
hsyuan merged 1 commit intoapache:masterfrom Sep 12, 2019
Merged
Conversation
hsyuan
reviewed
Sep 3, 2019
yanlin-Lynn
force-pushed
the
yanlin-correlate
branch
from
c58adcc to
a1129a3
Compare
Member
|
Sorry, my fault. I am wondering will changing |
Contributor
Author
Yes, compatibility issue might be a problem. I reset it to the previous commit. |
yanlin-Lynn
force-pushed
the
yanlin-correlate
branch
from
a1129a3 to
c58adcc
Compare
…on string (Wang Yanlin)
yanlin-Lynn
force-pushed
the
yanlin-correlate
branch
from
c58adcc to
9f36a98
Compare
Contributor
Author
|
There are many duplicate code in |
hsyuan
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullPointerExceptionandClassCastExceptionmay happen while deserializing LogicalCorrelate from json string.Please refer to CALCITE-3316 for the full stack trace of the exception.
This PR tries to fix it.