[CALCITE-3349] Add create and drop function into SqlKind ddl enumerations by HuangZhenQiu · Pull Request #1455 · apache/calcite

HuangZhenQiu · 2019-09-16T06:03:22Z

No description provided.

HuangZhenQiu · 2019-09-16T06:03:47Z

@suez1224 Would you please help and review this PR?

HuangZhenQiu · 2019-09-16T06:35:27Z

For the details, please refer to https://issues.apache.org/jira/browse/CALCITE-3349.

XuQianJin-Stars

+1, It is better to be able to add some tests.

HuangZhenQiu · 2019-09-17T04:08:56Z

@julianhyde
Would you please help to take a look this small PR?

danny0405

I don't know how to test either, but i'm okey on this change.

julianhyde · 2019-09-17T20:28:34Z

Be sure to fix capitalization in the commit message.

HuangZhenQiu · 2019-09-18T04:36:40Z

@julianhyde Thanks for pointing it out. I just updated the PR with a new commit log.

walterddr · 2019-09-18T22:50:40Z

server/src/main/java/org/apache/calcite/sql/ddl/SqlDropFunction.java

 */
-public class SqlDropFunction extends SqlDropObject {
+public class SqlDropFunction extends SqlDropObject
+    implements SqlExecutableStatement {


isn't SqlDropObject already implement SqlExecutableStatement ?

It is, but does not include create/drop function, we can remove the implements from SqlExecutableStatement.

julianhyde · 2019-09-19T16:52:19Z

Would it make sense to have a test for adding and dropping functions? Then we can all agree that this change is "complete".

danny0405 · 2019-09-20T01:33:38Z

@HuangZhenQiu Can you follow Julian's suggestion to add some tests ?

HuangZhenQiu · 2019-09-20T02:54:59Z

@julianhyde @danny0405 Sure. Will do in the next revision.

HuangZhenQiu · 2019-09-20T04:09:34Z

@danny0405 @julianhyde
As creating a function in a schema with an external jar needs quite an effort, I just added basic test case in this PR, and leave the full functionality in the following task https://issues.apache.org/jira/browse/CALCITE-3358

danny0405 · 2019-09-20T06:45:42Z

server/src/test/java/org/apache/calcite/test/ServerTest.java

+      } catch (SQLException e) {
+        assertThat(e.getMessage(),
+                containsString("Error while executing SQL \"drop function t\":" +
+                        " At line 1, column 15: Type 'T' not found"));


We should also throw exception message as "XXX not support" instead "XXX not found".

I added the default execution logic in SqlDrop for SqlDropFunction, so it will throw function not found in the root schema.

Yean, i mean we do not even support "drop function" then why throws "xxx function not found" ?

Oops, my mistake, you actually implement the "Drop function". Then we should add more tests about drop function:

Positive tests

Add a function in the schema and test remove with(without) if exists

Test drop function with specified catalog name and database name, i.e. DROP FUNCTION catalog_name.db_name.func_name

Negative tests

Test drop function what does not exist

Test drop function with case_sensive true but not found

@danny0405
Agree. If the create function is implemented, more test cases are needed. Currently, as the create function is not there, I can't add and drop function in test case. Thus, I would put the implementation of create and drop function in another PR, and leave this PR simple.

We do not need the create function to be implemented, just put the function explicitly into the schema is ok, then we can add drop function test.

@danny0405 I enhanced the test cases for drop function. But the namespace lookup of catalog_name.db_name is not handled for all table, function, and view. It requires a bigger change, so I would like to leave it as another PR. How do you think?

I'm fine with the latest change, thanks.

Close apache#1455

Close apache#1455 Change-Id: Id3b8cdcf31879db5a8a7db43b1e60bd8e1b33e4e

HuangZhenQiu changed the title ~~add create/drop function into SqlKind DDL enum~~ [CALCITE-3349] add create/drop function into SqlKind DDL enum Sep 16, 2019

XuQianJin-Stars reviewed Sep 16, 2019

View reviewed changes

julianhyde force-pushed the master branch from 2c19098 to f3758a6 Compare September 16, 2019 17:44

danny0405 changed the title ~~[CALCITE-3349] add create/drop function into SqlKind DDL enum~~ [CALCITE-3349] Add CREATE and DROP FUNCTION into SqlKind DDL enumerations Sep 17, 2019

danny0405 approved these changes Sep 17, 2019

View reviewed changes

danny0405 added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Sep 17, 2019

suez1224 approved these changes Sep 17, 2019

View reviewed changes

HuangZhenQiu changed the title ~~[CALCITE-3349] Add CREATE and DROP FUNCTION into SqlKind DDL enumerations~~ [CALCITE-3349] Add create and drop function into SqlKind ddl enumerations Sep 18, 2019

walterddr reviewed Sep 18, 2019

View reviewed changes

danny0405 reviewed Sep 20, 2019

View reviewed changes

HuangZhenQiu force-pushed the CALCITE-3349-add-funtion-enum branch from 578ec23 to 79228e6 Compare September 25, 2019 05:15

danny0405 added tests-missing and removed LGTM-will-merge-soon Overall PR looks OK. Only minor things left. labels Sep 25, 2019

HuangZhenQiu force-pushed the CALCITE-3349-add-funtion-enum branch 2 times, most recently from 570ba21 to 3448700 Compare September 26, 2019 22:28

HuangZhenQiu added 5 commits September 26, 2019 16:13

add create/drop function into SqlKind DDL enum

de69044

resolve shuyi's comments

5b1689c

add basic test cases

4a896bd

fix lint

106360d

enhance drop function test cases

1ff85b6

HuangZhenQiu force-pushed the CALCITE-3349-add-funtion-enum branch from 3448700 to 1ff85b6 Compare September 26, 2019 23:14

danny0405 added LGTM-will-merge-soon Overall PR looks OK. Only minor things left. and removed tests-missing labels Sep 29, 2019

hsyuan closed this in c09f293 Oct 3, 2019

XuQianJin-Stars pushed a commit to XuQianJin-Stars/calcite that referenced this pull request Nov 17, 2019

[CALCITE-3349] Add CREATE FUNCTION and DROP FUNCTION ddl (Zhenqiu Huang)

5ecce5b

Close apache#1455

XuQianJin-Stars pushed a commit to XuQianJin-Stars/calcite that referenced this pull request Nov 20, 2019

[CALCITE-3349] Add CREATE FUNCTION and DROP FUNCTION ddl (Zhenqiu Huang)

0192bdc

Close apache#1455

XuQianJin-Stars pushed a commit to XuQianJin-Stars/calcite that referenced this pull request Nov 20, 2019

[CALCITE-3349] Add CREATE FUNCTION and DROP FUNCTION ddl (Zhenqiu Huang)

83c9c41

Close apache#1455

wangxlong pushed a commit to wangxlong/calcite that referenced this pull request Feb 13, 2020

[CALCITE-3349] Add CREATE FUNCTION and DROP FUNCTION ddl (Zhenqiu Huang)

d71ae53

Close apache#1455

jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Aug 28, 2025

[CALCITE-3349] Add CREATE FUNCTION and DROP FUNCTION ddl (Zhenqiu Huang)

422e137

Close apache#1455 Change-Id: Id3b8cdcf31879db5a8a7db43b1e60bd8e1b33e4e

jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Mar 16, 2026

[CALCITE-3349] Add CREATE FUNCTION and DROP FUNCTION ddl (Zhenqiu Huang)

59a7dfd

Close apache#1455 Change-Id: Id3b8cdcf31879db5a8a7db43b1e60bd8e1b33e4e

Conversation

HuangZhenQiu commented Sep 16, 2019

Uh oh!

HuangZhenQiu commented Sep 16, 2019

Uh oh!

HuangZhenQiu commented Sep 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XuQianJin-Stars left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HuangZhenQiu commented Sep 17, 2019

Uh oh!

danny0405 left a comment

Choose a reason for hiding this comment

Uh oh!

julianhyde commented Sep 17, 2019

Uh oh!

HuangZhenQiu commented Sep 18, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julianhyde commented Sep 19, 2019

Uh oh!

danny0405 commented Sep 20, 2019

Uh oh!

HuangZhenQiu commented Sep 20, 2019

Uh oh!

HuangZhenQiu commented Sep 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HuangZhenQiu commented Sep 16, 2019 •

edited

Loading

XuQianJin-Stars left a comment •

edited

Loading