[CALCITE-3388] StackOverflowError for creating structured RelDataType from class type#1486
Closed
yanlin-Lynn wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3388] StackOverflowError for creating structured RelDataType from class type#1486yanlin-Lynn wants to merge 1 commit intoapache:masterfrom
yanlin-Lynn wants to merge 1 commit intoapache:masterfrom
Conversation
yanlin-Lynn
changed the title
hsyuan
reviewed
Oct 5, 2019
| final List<RelDataTypeField> list = new ArrayList<>(); | ||
| for (Field field : type.getFields()) { | ||
| if (!Modifier.isStatic(field.getModifiers())) { | ||
| // FIXME: watch out for recursion |
yanlin-Lynn
force-pushed
the
struct-recursion
branch
from
8774922 to
98a8cab
Compare
yanlin-Lynn
changed the title
hsyuan
reviewed
Oct 5, 2019
core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java
Outdated
Show resolved
Hide resolved
… from class type (Wang Yanlin) Check for recursion and throw an exception with message showing recursion not supported
yanlin-Lynn
force-pushed
the
struct-recursion
branch
from
98a8cab to
f731585
Compare
Contributor
Author
|
Seems unnecessary, I'll just close this PR. We can reopen it when it really happends. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a structured RelDataType from a java type with recursion reference, StackOverflowError occurs. See jira CALCITE-3388 for full stack trace.
This PR tries to check for recursion and throw an exception with message showing recursion not supported