[CALCITE-3592] Implement bitnot scalar function#1672
Open
wangxlong wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-3592] Implement bitnot scalar function#1672wangxlong wants to merge 1 commit intoapache:mainfrom
wangxlong wants to merge 1 commit intoapache:mainfrom
Conversation
wangxlong
force-pushed
the
CALCITE-3592
branch
2 times, most recently
from
3f74be2 to
c959e07
Compare
chunweilei
reviewed
Dec 18, 2019
| public class SqlBitNotOperator extends SqlPrefixOperator { | ||
|
|
||
| SqlBitNotOperator() { | ||
| super("~", SqlKind.BITNOT, 0, ReturnTypes.ARG0_NULLABLE_IF_EMPTY, |
Contributor
There was a problem hiding this comment.
IMO, no need to create an extra class.
Contributor
Author
There was a problem hiding this comment.
Thank you @chunweilei . I have delete extra class.
vlsi
force-pushed
the
master
branch
2 times, most recently
from
49cb002 to
8768a23
Compare
wangxlong
force-pushed
the
CALCITE-3592
branch
from
a3d18c1 to
27d5b1e
Compare
wangxlong
force-pushed
the
CALCITE-3592
branch
from
27d5b1e to
85439d9
Compare
wangxlong
changed the title
danny0405
changed the title
danny0405
approved these changes
Feb 17, 2020
Contributor
danny0405
left a comment
danny0405
left a comment
There was a problem hiding this comment.
+1, from the doc of SnowFlake, there is not need to add any syntax extension to Babel ~
[1] https://docs.snowflake.net/manuals/sql-reference/functions/bitnot.html
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement bitnot scalar function
See jira CALCIT-3592