Skip to content

[CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor#1692

Closed
xy2953396112 wants to merge 2 commits intoapache:masterfrom
xy2953396112:IntersectToIntersect
Closed

[CALCITE-3632] Add IntersectToIntersectUnify Rule in SubstitutionVisitor#1692
xy2953396112 wants to merge 2 commits intoapache:masterfrom
xy2953396112:IntersectToIntersect

Conversation

@xy2953396112
Copy link
Copy Markdown
Contributor

@Test public void testIntersectToIntersect0() {
final String mv = ""
+ "select \"deptno\" from\n"
+ "\"emps\" intersect select \"deptno\" from \"depts\"";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant spaces ?

checkMaterialize(mv, query, true);
}

@Test public void testIntersectToIntersect1() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about format like below:

select deptno from emps
intersect
select deptno  from depts;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, update code.

@jinxing64
Copy link
Copy Markdown
Contributor

Just minor comments ~
BTW, this is another case that tests added just for SubstitutionVisitor ~
If committer starts review this one, it will be great that #1560 can also be taken into consideration.

@zabetak zabetak closed this in 5ddded1 Dec 29, 2019
wangxlong pushed a commit to wangxlong/calcite that referenced this pull request Feb 13, 2020
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Aug 28, 2025
apache#45)

…tor (xy2953396112)

Close apache#1692

Co-authored-by: dz <953396112@qq.com>
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Mar 16, 2026
apache#45)

…tor (xy2953396112)

Close apache#1692

Co-authored-by: dz <953396112@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants