[CALCITE-3262] Refine doc of SubstitutionVisitor#1734
Closed
xy2953396112 wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3262] Refine doc of SubstitutionVisitor#1734xy2953396112 wants to merge 1 commit intoapache:masterfrom
xy2953396112 wants to merge 1 commit intoapache:masterfrom
Conversation
xy2953396112
changed the title
danny0405
reviewed
Jan 8, 2020
| * {@link org.apache.calcite.rel.core.Join}, | ||
| * {@link org.apache.calcite.rel.core.Union}, | ||
| * {@link org.apache.calcite.rel.core.Intersect}, | ||
| * {@link org.apache.calcite.rel.core.Sort}, |
Contributor
There was a problem hiding this comment.
Doc like enumerating the classes are hard to maintain, people should always remember to update the references, let's avoid to make such kind of doc.
Contributor
Author
There was a problem hiding this comment.
Thanks for you review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this pr, JIRA: https://issues.apache.org/jira/browse/CALCITE-3262 refine the doc.
this pr refine doc for
Calc、Intersect、Sortrelational operators in SubstitutionVisitor.