[CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception#1759
Closed
XuQianJin-Stars wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception#1759XuQianJin-Stars wants to merge 1 commit intoapache:masterfrom
XuQianJin-Stars wants to merge 1 commit intoapache:masterfrom
Conversation
hsyuan
reviewed
Jan 15, 2020
| dumpGraphviz(pw); | ||
| } | ||
| } catch (Exception ex) { | ||
| throw new AssertionError("Dumps the internal state ", ex); |
Member
There was a problem hiding this comment.
If we change this way, we won't see CannotPlanException
Member
There was a problem hiding this comment.
you shouldn't throw an exception or error here.
XuQianJin-Stars
force-pushed
the
CALCITE-3676
branch
from
b682e61 to
06c97b4
Compare
Contributor
|
-1: the change ignores the exception, so it would be hard to analyze failures in production |
hsyuan
reviewed
Jan 18, 2020
| pw.println(); | ||
| pw.println("Graphviz:"); | ||
| dumpGraphviz(pw); | ||
| pw.print(ex); |
Member
There was a problem hiding this comment.
Can we change to
pw.println("Error when dumping plan state: \n" + e);
XuQianJin-Stars
force-pushed
the
CALCITE-3676
branch
from
c81d480 to
510b164
Compare
hsyuan
pushed a commit
that referenced
this pull request
Jan 28, 2020
…acefully (Qianjin Xu) Close #1759
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…acefully (Qianjin Xu) Close apache#1759
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
apache#91) …acefully (Qianjin Xu) Close apache#1759 Co-authored-by: XuQianJin-Stars <x1q1j1@163.com>
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#91) …acefully (Qianjin Xu) Close apache#1759 Co-authored-by: XuQianJin-Stars <x1q1j1@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As illustrated in CALCITE-3676