[CALCITE-3810, CALCITE-3840] Rel-to-Sql translation for ANTI and SEMI join and VALUES clause re-aliasing fix#1819
Closed
beikov wants to merge 2 commits intoapache:masterfrom
Closed
[CALCITE-3810, CALCITE-3840] Rel-to-Sql translation for ANTI and SEMI join and VALUES clause re-aliasing fix#1819beikov wants to merge 2 commits intoapache:masterfrom
beikov wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Great work, would review if i have time ~ |
beikov
force-pushed
the
CALCITE-3810
branch
2 times, most recently
from
0b74d4b to
572bb80
Compare
beikov
changed the title
…the JDBC adapter. Also add forgotten IS_DISTINCT_FROM translation support
… wrong SQL in the JDBC adapter
Contributor
Author
|
Hey @julianhyde and @danny0405 |
danny0405
approved these changes
Mar 23, 2020
Contributor
danny0405
left a comment
danny0405
left a comment
There was a problem hiding this comment.
+1, looks good from my side.
Contributor
Author
|
Thanks, merged via 893d41f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test and fix for https://issues.apache.org/jira/browse/CALCITE-3810 and https://issues.apache.org/jira/browse/CALCITE-3840