[CALCITE-3828] MergeJoin throws NPE in case of null keys#1833
Merged
rubenada merged 1 commit intoapache:masterfrom Mar 6, 2020
Merged
[CALCITE-3828] MergeJoin throws NPE in case of null keys#1833rubenada merged 1 commit intoapache:masterfrom
rubenada merged 1 commit intoapache:masterfrom
Conversation
chunweilei
reviewed
Feb 26, 2020
vlsi
reviewed
Feb 26, 2020
rubenada
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: CALCITE-3828
EnumerableDefaults#MergeJoinEnumerator throws a NPE in case of null keys.
MergeJoin algorithm assumes that inputs sorted in ascending order, with nulls last (see EnumerableMergeJoinRule), so when reaching a null key on the left / right side means that we are done.