[CALCITE-3852] RexSimplify doesn't simplify NOT EQUAL predicates#1854
Merged
chunweilei merged 1 commit intoapache:masterfrom Mar 18, 2020
Merged
[CALCITE-3852] RexSimplify doesn't simplify NOT EQUAL predicates#1854chunweilei merged 1 commit intoapache:masterfrom
chunweilei merged 1 commit intoapache:masterfrom
Conversation
kgyrtkirk
reviewed
Mar 12, 2020
chunweilei
force-pushed
the
CALCITE-3852
branch
2 times, most recently
from
611fc99 to
7ab36fd
Compare
hsyuan
reviewed
Mar 17, 2020
hsyuan
added
the
LGTM-will-merge-soon
kgyrtkirk
reviewed
Mar 17, 2020
Member
kgyrtkirk
left a comment
kgyrtkirk
left a comment
There was a problem hiding this comment.
sorry for the late notes @chunweilei ; I didn't got the notification about that you've update the patch...
Contributor
Author
|
Thank you for your review, @kgyrtkirk and @hsyuan . |
chunweilei
force-pushed
the
CALCITE-3852
branch
from
2a073b9 to
c5be921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.