Skip to content

[CALCITE-3853] Minor improvements in SortJoinCopyRule#1857

Merged
rubenada merged 1 commit intoapache:masterfrom
rubenada:CALCITE-3853
Mar 12, 2020
Merged

[CALCITE-3853] Minor improvements in SortJoinCopyRule#1857
rubenada merged 1 commit intoapache:masterfrom
rubenada:CALCITE-3853

Conversation

@rubenada
Copy link
Copy Markdown
Contributor

@rubenada rubenada commented Mar 12, 2020

Jira: CALCITE-3853.

Several improvements can be made on SortJoinCopyRule (introduced via CALCITE-2624):

  • The default INSTANCE currently matches LogicalSort + Join, which seems inconsistent, it should match LogicalSort + LogicalJoin
  • The constructor should be public, in order to allow clients to create their own version of the rule

danny0405
danny0405 approved these changes Mar 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rubenada rubenada added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Mar 12, 2020
@rubenada rubenada merged commit bc2d7e1 into apache:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danny0405 danny0405 danny0405 approved these changes

Assignees

No one assigned

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rubenada @danny0405