[CALCITE-3948] Improve operand's RelSubset matching handling in VolcanoRuleCall#1935
Closed
hbtoo wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3948] Improve operand's RelSubset matching handling in VolcanoRuleCall#1935hbtoo wants to merge 1 commit intoapache:masterfrom
hbtoo wants to merge 1 commit intoapache:masterfrom
Conversation
hsyuan
reviewed
Apr 21, 2020
| if (clazz == RelSubset.class) { | ||
| // Only supports matching subset for leaf operand | ||
| assert children.size() == 0; | ||
| } |
Member
There was a problem hiding this comment.
Perhaps we don't need this, rule operand should be HepPlanner/VolcanoPlanner agnostic?
hsyuan
reviewed
Apr 21, 2020
| public Stream<RelSubset> getSubsetsSatisfingThis() { | ||
| return set.subsets.stream() | ||
| .filter(s -> s.getTraitSet().satisfies(traitSet)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Can we add this as a public api? This one is very similar to getParentRels(), getRels(), except that it is looking for relationships of RelSubset rather than rels.
hbtoo
force-pushed
the
CALCITE-3948
branch
2 times, most recently
from
d755d67 to
18dd467
Compare
danny0405
changed the title
hsyuan
reviewed
Apr 23, 2020
| } | ||
|
|
||
| @API(since = "1.23", status = API.Status.EXPERIMENTAL) | ||
| public Stream<RelSubset> getSatisfyingSubsets() { |
hsyuan
approved these changes
Apr 23, 2020
hsyuan
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-3948