[CALCITE-3950] Doc of SqlGroupingFunction contradicts its behavior#1940
Merged
jinxing64 merged 1 commit intoapache:masterfrom May 19, 2020
Merged
[CALCITE-3950] Doc of SqlGroupingFunction contradicts its behavior#1940jinxing64 merged 1 commit intoapache:masterfrom
jinxing64 merged 1 commit intoapache:masterfrom
Conversation
jinxing64
force-pushed
the
CALCITE-3950
branch
3 times, most recently
from
1e4bdcb to
501380f
Compare
Contributor
|
+1 for updating the Javadoc. |
Contributor
Author
|
Sure ~ update soon |
jinxing64
force-pushed
the
CALCITE-3950
branch
3 times, most recently
from
bf470d3 to
86543df
Compare
Contributor
|
LGTM |
Contributor
Author
|
@DonnyZone Thanks I will re-trigger the CI |
jinxing64
force-pushed
the
CALCITE-3950
branch
2 times, most recently
from
3396c31 to
c854a6d
Compare
Contributor
Author
|
travis-ci keeps failing. It seems the building environment has problem. |
jinxing64
force-pushed
the
CALCITE-3950
branch
2 times, most recently
from
e925024 to
d68bef1
Compare
jinxing64
force-pushed
the
CALCITE-3950
branch
2 times, most recently
from
5d0bdf0 to
965139b
Compare
Contributor
Author
|
Since @DonnyZone gives +1 for this change. I will add a LGTM-will-merge-soon tag. Welcome further comments and I will update ASAP before merging. |
jinxing64
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.