[CALCITE-3539] Implement INSTR function#1946
Closed
xy2953396112 wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3539] Implement INSTR function#1946xy2953396112 wants to merge 1 commit intoapache:masterfrom
xy2953396112 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Do we also need to update reference.md ? |
xy2953396112
force-pushed
the
instr_functions
branch
3 times, most recently
from
8efc738 to
9406c0a
Compare
Contributor
Author
Thanks, i have updated reference.md. |
chunweilei
reviewed
Apr 29, 2020
| tester1.checkString("INSTR('foobarbar', 'bar')", "4", "INTEGER NOT NULL"); | ||
| tester1.checkString("INSTR('bar', 'foobarbar')", "0", "INTEGER NOT NULL"); | ||
| tester1.checkNull("INSTR('foobarbar', cast(null as varchar(1)))"); | ||
| tester1.checkNull("INSTR(cast(null as varchar(1)), 'foobarbar')"); |
Contributor
There was a problem hiding this comment.
Could you also add negative tests?
DonnyZone
reviewed
Apr 30, 2020
site/_docs/reference.md
Outdated
| | m | SPACE(integer) | Returns a string of *integer* spaces; returns an empty string if *integer* is less than 1 | ||
| | o | SUBSTR(string, position [, substringLength ]) | Returns a portion of *string*, beginning at character *position*, *substringLength* characters long. SUBSTR calculates lengths using characters as defined by the input character set | ||
| | m | STRCMP(string, string) | Returns 0 if both of the strings are same and returns -1 when the first argument is smaller than the second and 1 when the second one is smaller the first one. | ||
| | m | INSTR(string, string) | Returns the index of the first occurrence of the second argument in the first argument and returns 0 if the first argument not include the second argument. |
Contributor
There was a problem hiding this comment.
We'd better remove the period at the end of the description.
Contributor
There was a problem hiding this comment.
well, STRCMP does the same, change it altogether
Contributor
|
MySQL's document says: ' |
site/_docs/reference.md
Outdated
| | m | SPACE(integer) | Returns a string of *integer* spaces; returns an empty string if *integer* is less than 1 | ||
| | o | SUBSTR(string, position [, substringLength ]) | Returns a portion of *string*, beginning at character *position*, *substringLength* characters long. SUBSTR calculates lengths using characters as defined by the input character set | ||
| | m | STRCMP(string, string) | Returns 0 if both of the strings are same and returns -1 when the first argument is smaller than the second and 1 when the second one is smaller the first one. | ||
| | m | INSTR(string, string) | Returns the index of the first occurrence of the second argument in the first argument and returns 0 if the first argument not include the second argument. |
Contributor
There was a problem hiding this comment.
Please move the description here and sort by alphabet.
Contributor
|
hi @xy2953396112 There is an error in the title here, it should be the link https://issues.apache.org/jira/browse/CALCITE-3959 |
xy2953396112
force-pushed
the
instr_functions
branch
from
9406c0a to
20d8309
Compare
xy2953396112
force-pushed
the
instr_functions
branch
from
20d8309 to
3f1a38b
Compare
Contributor
|
looks good overall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.