[CALCITE-3517] Rework DiffRepository as a JUnit extension#1962
Open
laurentgo wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-3517] Rework DiffRepository as a JUnit extension#1962laurentgo wants to merge 1 commit intoapache:mainfrom
laurentgo wants to merge 1 commit intoapache:mainfrom
Conversation
laurentgo
force-pushed
the
laurentgo/CALCITE-3517
branch
2 times, most recently
from
244c11a to
2bb2e9f
Compare
Introduce JUnit DiffRepositoryExtension extension to manage concurrent access to DiffRepository instances by test classes, and dumping their content on disk at the end of the test run. DiffRepositoryExtension automatically injects DiffRepository instance to the constructor based on the test class, but a different repository can be used by using the DiffRepositoryName annotation. Update all the tests using DiffRepository to leverage the extension. Cleanup DiffRepository class, and remove all unused code.
laurentgo
force-pushed
the
laurentgo/CALCITE-3517
branch
from
2bb2e9f to
320434f
Compare
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce JUnit DiffRepositoryExtension extension to manage concurrent access to DiffRepository instances by test classes, and dumping their content on disk at the end of the test run.
DiffRepositoryExtension automatically injects DiffRepository instance to the constructor based on the test class, but a different repository can be used by using the DiffRepositoryName annotation.
Update all the tests using DiffRepository to leverage the extension.
Cleanup DiffRepository class, and remove all unused code.