[CALCITE-3980] Improvement for creating RedisTable#1965
Closed
neoremind wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-3980] Improvement for creating RedisTable#1965neoremind wants to merge 1 commit intoapache:masterfrom
neoremind wants to merge 1 commit intoapache:masterfrom
Conversation
neoremind
changed the title
Contributor
|
LGTM! |
Contributor
|
LGTM +1 |
Contributor
|
@neoremind could you please modify the commit message following the document? Thanks! |
DonnyZone
added
the
LGTM-will-merge-soon
Contributor
Author
|
@DonnyZone Sure, done. Would you help to check? Many thanks. Also thanks Forward to look into this 😄 |
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#370) …sTable is created (Xu Zhang) When creating RedisTable via ModelHandler, it relies on an instance method RedisEnumerator#deduceRowType to extract field type map, redis connection will be established and closed every time a table is created, which is unnecessary and redundant, so simply make the method a static one will solve the problem and make it more performant. CsvTable implementation works the right way. Close apache#1965 Co-authored-by: xu <xu.zx@alibaba-inc.com>
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#370) …sTable is created (Xu Zhang) When creating RedisTable via ModelHandler, it relies on an instance method RedisEnumerator#deduceRowType to extract field type map, redis connection will be established and closed every time a table is created, which is unnecessary and redundant, so simply make the method a static one will solve the problem and make it more performant. CsvTable implementation works the right way. Close apache#1965 Co-authored-by: xu <xu.zx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-3980