[CALCITE-3987] Coerce NUMERIC to INTERVAL_DAY in DATE arithmetic#1984
Closed
dasch-1 wants to merge 1 commit intoapache:masterfrom
dasch-1:date_numeric_3987
Closed
[CALCITE-3987] Coerce NUMERIC to INTERVAL_DAY in DATE arithmetic#1984dasch-1 wants to merge 1 commit intoapache:masterfrom dasch-1:date_numeric_3987
dasch-1 wants to merge 1 commit intoapache:masterfrom
dasch-1:date_numeric_3987
Conversation
danny0405
reviewed
May 20, 2020
| } | ||
| SqlCall call = binding.getCall(); | ||
| SqlNumericLiteral numeric = (SqlNumericLiteral) call.getOperandList().get(numericIndex); | ||
| SqlIntervalQualifier qualifier = |
Contributor
There was a problem hiding this comment.
How would you make sure the numeric operand is a literal ? Could it be another expression ?
Contributor
There was a problem hiding this comment.
Why not just add a CAST there, let the planner decide how to translate to interval value.
| expr("CURRENT_DATE+1") | ||
| .withConformance(SqlConformanceEnum.BABEL).ok(); | ||
| expr("1+CURRENT_DATE") | ||
| .withConformance(SqlConformanceEnum.BABEL).ok(); |
Contributor
There was a problem hiding this comment.
We better also check the type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.