[CALCITE-3975] Add options to ProjectFilterTransposeRule to push down project and filter expressions whole, not just field references #1999
Closed
julianhyde wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Make mutable field RelOptUtil.InputFinder.inputBitSet private. The field still exists, public and deprecated, but it shadows a new private field. Rather than calling InputFinder.inputBitSet.build() you should now call InputFinder.build(). In RexVisitor and RexBiVisitor add methods visitList and visitEach (the former returns a list, and the latter returns void). Deprecate RexShuttle.apply in favor of visitList. Add RexWindowBound.accept(RexBiVisitor). For RexBiVisitor<X, Integer> add a method visitEachIndexed, the index passed as the 'payload' argument. Add abstract implementations of RexBiVisitor: RexUnaryBiVisitor and RexBiVisitorImpl.
… project and filter expressions whole, not just field references Close apache#1999
julianhyde
force-pushed
the
3975-project-filter
branch
from
1b07879 to
a45f46b
Compare
hsyuan
approved these changes
Jun 3, 2020
Member
hsyuan
left a comment
hsyuan
left a comment
There was a problem hiding this comment.
+1
The rexnode visitor is a really nice refactoring. Thanks!
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Jun 10, 2020
… project and filter expressions whole, not just field references Close apache#1999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/CALCITE-3975.