[CALCITE-4085] Improve nullability support for fields of structured types#2042
Closed
dawidwys wants to merge 2 commits intoapache:masterfrom
Closed
[CALCITE-4085] Improve nullability support for fields of structured types#2042dawidwys wants to merge 2 commits intoapache:masterfrom
dawidwys wants to merge 2 commits intoapache:masterfrom
Conversation
dawidwys
force-pushed
the
improve-nullability
branch
from
3184200 to
98bf85a
Compare
SqlItemOperator This PR introduces a logic that makes the accesed field nullable if the accessed row is nullable.
Make the AliasNamespace keep the original nullability & StructKing of the aliased record.
dawidwys
force-pushed
the
improve-nullability
branch
from
98bf85a to
949ff81
Compare
dawidwys
changed the title
Contributor
Author
|
Do you mind having a look @danny0405 ? |
Contributor
|
LGTM |
danny0405
added
the
accepted-and-would-rework-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to improve nullability of records fields when the record itself is nullable,
The PR is split into three commits which in my opinion affect the code base to a different extent. Calcite users should not see a difference in the behaviour, but downstream projects that depend on Calcite can implement a support for not null fields within a nullable record type based on those changes.