[CALCITE-4177] Throw exception when deserialize SqlOperator fails, do not return null#2110
[CALCITE-4177] Throw exception when deserialize SqlOperator fails, do not return null#2110yanlin-Lynn wants to merge 1 commit intoapache:masterfrom
Conversation
| } | ||
| return null; | ||
| throw new RuntimeException("No operator for " + name + " with kind: " | ||
| + kind + ", and syntax: " + syntax); |
There was a problem hiding this comment.
Will it better to move this exception in CalciteResource.java?
There was a problem hiding this comment.
yes, I'll update
There was a problem hiding this comment.
Is this a breaking change ? Do you know the background that it returns null before ?
There was a problem hiding this comment.
Yes, this breaks a little. I don't know the background why it returns null before.
Hopes someone can help to give the background, but I doubt there exists some special reason, because null will always cause NPE somewhere else.
|
We better also add some tests there ~ |
yanlin-Lynn
force-pushed
the
rexnode_deser
branch
from
3ea6355 to
72982c4
Compare
Thanks for review. But I didn't get your point, there is a test case already. |
Oops, i didn't saw that ~ |
yanlin-Lynn
force-pushed
the
rexnode_deser
branch
3 times, most recently
from
ab88c6a to
da15f9a
Compare
… not return null (Wang Yanlin)
yanlin-Lynn
force-pushed
the
rexnode_deser
branch
from
da15f9a to
a8de283
Compare
|
LGTM~, Can you fix the CI? |
|
Closed in ce86af8. |
7 participants
See jira CALCITE-4177