[CALCITE-4230] In Babel for BigQuery, split quoted table names that contain dots#2147
Merged
julianhyde merged 7 commits intoapache:masterfrom Sep 18, 2020
Merged
Conversation
julianhyde
force-pushed
the
4230-babel-big-query
branch
from
4b897ec to
71b8b63
Compare
Store StringAndPos rather than the SQL string in a test. This makes it easier to write positive and negative tests on same SQL string, because we don't have to keep the carets (that indicate the error position) in the SQL string. If you want real carets in a SQL string, you can now write "^^". Remove the sansCarets() method, as it is no longer necessary. Pass SqlDialect into negative and expression tests. Add constants in SqlParserTest for common dialects.
…le names that contain dots
…able names to contain hyphens
…ls may be enclosed in single- or double-quotes, and use backslashes as escapes In enum Lex, add new constant BIG_QUERY; add enum CharLiteralStyle.
…ty values of type List, Set or Map Add class ImmutableNullableSet.
Fix bug translating Sarg to SQL, and add a test case for it. (The test case only demonstrates the bug on [CALCITE-4262] branch, where SqlToRelCovnerter uses RelBuilder.filter rather than LogicalFilter.create, and therefore introduces a Sarg.)
julianhyde
force-pushed
the
4230-babel-big-query
branch
from
b12c4d7 to
6a3a7e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.