Skip to content

[CALCITE-4390] Fix SqlMatchRecognize operand list#2254

Merged
rubenada merged 1 commit intoapache:masterfrom
dawidwys:CALCITE-4390
Nov 12, 2020
Merged

[CALCITE-4390] Fix SqlMatchRecognize operand list#2254
rubenada merged 1 commit intoapache:masterfrom
dawidwys:CALCITE-4390

Conversation

@dawidwys
Copy link
Contributor

The PR fixes the list of returned operands in SqlMatchRecognize. Without the change e.g. SqlShuttle cannot be used with MATCH_RECOGNIZE clause.

@rubenada
Copy link
Contributor

LGTM

Thanks for the PR @dawidwys . Some minor details to correct the commit message (as per https://calcite.apache.org/develop/#contributing):

  • The commit message should describe the issue, and should not begin with "Fix ...". IMHO the Jira title ("SqlMatchRecognize returns wrong operand list") would be a more adequate commit message.
  • The commit message should end with your name & last name in parentheses.

@dawidwys
Copy link
Contributor Author

dawidwys commented Nov 11, 2020

Sorry for not abiding by the guide. I updated the commit message according to your suggestion.

@rubenada rubenada added slow-tests-needed LGTM-will-merge-soon Overall PR looks OK. Only minor things left. labels Nov 11, 2020
@rubenada rubenada merged commit 0ce7685 into apache:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left. slow-tests-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants