[CALCITE-4424] Complete non-deterministic function (Jiatao Tao)

core/src/main/java/org/apache/calcite/sql/fun/SqlAbstractTimeFunction.java

@@ -88,4 +88,8 @@ protected SqlAbstractTimeFunction(String name, SqlTypeName typeName) {
   @Override public boolean isDynamicFunction() {
     return true;
   }
+
+  @Override public boolean isDeterministic() {
+    return false;
+  }
 }

core/src/main/java/org/apache/calcite/sql/fun/SqlBaseContextVariable.java

@@ -53,4 +53,8 @@ protected SqlBaseContextVariable(String name,
   @Override public boolean isDynamicFunction() {
     return true;
   }
+
+  @Override public boolean isDeterministic() {
+    return false;
+  }
 }

core/src/main/java/org/apache/calcite/sql/fun/SqlCurrentDateFunction.java

@@ -55,4 +55,8 @@ public SqlCurrentDateFunction() {
   @Override public boolean isDynamicFunction() {
     return true;
   }
+
+  @Override public boolean isDeterministic() {
+    return false;
+  }
 }

core/src/main/java/org/apache/calcite/sql/fun/SqlRandFunction.java

@@ -54,4 +54,8 @@ public SqlRandFunction() {
   @Override public boolean isDynamicFunction() {
     return true;
   }
+
+  @Override public boolean isDeterministic() {
+    return false;
+  }
 }

core/src/main/java/org/apache/calcite/sql/fun/SqlRandIntegerFunction.java

@@ -54,4 +54,8 @@ public SqlRandIntegerFunction() {
   @Override public boolean isDynamicFunction() {
     return true;
   }
+
+  @Override public boolean isDeterministic() {
+    return false;
+  }
 }

core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java

@@ -312,6 +312,30 @@ private void testContextLiteral(
     });
   }
 
+  @Test void testNonDeterministicFunc() throws Exception {
+    check((rexBuilder, executor) -> {
+      // SqlRandFunction
+      final RexNode rand = rexBuilder.makeCall(SqlStdOperatorTable.RAND);
+      assertThat(RexUtil.isDeterministic(rand), equalTo(false));
+
+      // SqlRandIntegerFunction
+      final RexNode randInteger = rexBuilder.makeCall(SqlStdOperatorTable.RAND_INTEGER);
+      assertThat(RexUtil.isDeterministic(randInteger), equalTo(false));
+
+      // SqlCurrentDateFunction
+      final RexNode currentDate = rexBuilder.makeCall(SqlStdOperatorTable.CURRENT_DATE);
+      assertThat(RexUtil.isDeterministic(currentDate), equalTo(false));
+
+      // SqlBaseContextVariable
+      final RexNode user = rexBuilder.makeCall(SqlStdOperatorTable.USER);
+      assertThat(RexUtil.isDeterministic(user), equalTo(false));
+
+      // SqlAbstractTimeFunction
+      final RexNode localtime = rexBuilder.makeCall(SqlStdOperatorTable.LOCALTIME);
+      assertThat(RexUtil.isDeterministic(localtime), equalTo(false));
+    });
+  }
+
   private static final SqlBinaryOperator PLUS_RANDOM =
       new SqlMonotonicBinaryOperator(
           "+",

core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java

@@ -5619,7 +5619,7 @@ private void testSwapJoinShouldNotMatch(RelNode input) {
         + "group by sal, hiredate\n"
         + "having count(*) > 3";
     sql(sql).withRule(CoreRules.AGGREGATE_ANY_PULL_UP_CONSTANTS)
-        .check();
+        .checkUnchanged();
   }
 
   @Test void testReduceExpressionsNot() {

core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

@@ -11630,17 +11630,6 @@ LogicalProject(HIREDATE=[$1])
       LogicalProject(SAL=[$5], HIREDATE=[$4])
         LogicalFilter(condition=[AND(IS NULL($5), =($4, CURRENT_TIMESTAMP))])
           LogicalTableScan(table=[[CATALOG, SALES, EMP]])
-]]>
-        </Resource>
-        <Resource name="planAfter">
-            <![CDATA[
-LogicalProject(HIREDATE=[$1])
-  LogicalFilter(condition=[>($2, 3)])
-    LogicalProject(SAL=[$0], HIREDATE=[CURRENT_TIMESTAMP], $f2=[$1])
-      LogicalAggregate(group=[{0}], agg#0=[COUNT()])
-        LogicalProject(SAL=[$5])
-          LogicalFilter(condition=[AND(IS NULL($5), =($4, CURRENT_TIMESTAMP))])
-            LogicalTableScan(table=[[CATALOG, SALES, EMP]])
 ]]>
         </Resource>
     </TestCase>