[CALCITE-1235] Push down LIMIT in unfiltered Cassandra queries#229
Closed
michaelmior wants to merge 5 commits intoapache:masterfrom
Closed
[CALCITE-1235] Push down LIMIT in unfiltered Cassandra queries#229michaelmior wants to merge 5 commits intoapache:masterfrom
michaelmior wants to merge 5 commits intoapache:masterfrom
Conversation
michaelmior
force-pushed
the
1235-cassandra-limit
branch
from
7aca2e9 to
e955fbb
Compare
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#229) …xpr as BIGINT) as INT) => intExpr Co-authored-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#229) …xpr as BIGINT) as INT) => intExpr Co-authored-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd appreciate someone if someone could review this before I merge to see if maybe there's a better way to accomplish what I'm trying to do. In the current version of the Cassandra adapter, some overly specific matching is necessary to push down sorts because information is needed from other parts of the operator tree. This means that the current match rule will only pushes down LIMIT if the query has a filter.
This patch adds two additional rules to help deal with LIMIT. The first pushes down
EnumerableLimitand the second eliminates redundant adjacentCassandraSortoperators which can now occur because one rule matchesEnumerableLimitand the other matchesSort. They both can be handled by a single instance of operator so this makes the plan simpler.