[CALCITE-4618] Refine dependency declarations to better account for type annotations#2410
Closed
vlsi wants to merge 1 commit intoapache:mainfrom
Closed
[CALCITE-4618] Refine dependency declarations to better account for type annotations#2410vlsi wants to merge 1 commit intoapache:mainfrom
vlsi wants to merge 1 commit intoapache:mainfrom
Conversation
The updated dependency-analysis analyzes type annotations much better.
The command to analyze dependencies is
./gradlew -PenableDependencyAnalysis buildHealth
Contributor
|
Please log a JIRA case for this. |
Member
|
In the meantime, all the suspected false positives have been verified/fixed, so I think we are good to go now. PS: I did not know the tool, I wish there was a similar tool for Maven too, "manual" dependency management is hard! |
asolimando
approved these changes
Sep 11, 2021
Contributor
Author
|
I'm not interested in moving this forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated dependency-analysis analyzes type annotations much better.
The command to analyze dependencies is
The following warnings are still present (I believe they are false positives, however, the one regarding xerces is weird and we can either skip that dependency or declare it as implementation):
autonomousapps/dependency-analysis-gradle-plugin#393
autonomousapps/dependency-analysis-gradle-plugin#392
autonomousapps/dependency-analysis-gradle-plugin#394
In practice, xerces:xercesImpl is pulled to the
implementationscope by spark->hadoop anyway, so there's no much sense in declaring xerces explicitly as we don't use it.