Skip to content

[CALCITE-4618] Refine dependency declarations to better account for type annotations#2410

Closed
vlsi wants to merge 1 commit intoapache:mainfrom
vlsi:align_dependencies2
Closed

[CALCITE-4618] Refine dependency declarations to better account for type annotations#2410
vlsi wants to merge 1 commit intoapache:mainfrom
vlsi:align_dependencies2

Conversation

@vlsi
Copy link
Contributor

@vlsi vlsi commented May 6, 2021

The updated dependency-analysis analyzes type annotations much better.

The command to analyze dependencies is

./gradlew -PenableDependencyAnalysis buildHealth

The following warnings are still present (I believe they are false positives, however, the one regarding xerces is weird and we can either skip that dependency or declare it as implementation):

autonomousapps/dependency-analysis-gradle-plugin#393

  Advice for project :core
  Existing dependencies which should be modified to be as indicated:
  - testImplementation("org.apache.commons:commons-dbcp2:2.6.0") (was implementation)

autonomousapps/dependency-analysis-gradle-plugin#392

  Plugin advice:
  - java-library: this project has both java-library and org.jetbrains.kotlin.jvm applied, which is redundant. You can remove java-library

autonomousapps/dependency-analysis-gradle-plugin#394
In practice, xerces:xercesImpl is pulled to the implementation scope by spark->hadoop anyway, so there's no much sense in declaring xerces explicitly as we don't use it.

  Advice for project :spark
  Existing dependencies which should be modified to be as indicated:
  - implementation("xerces:xercesImpl:2.9.1") (was runtimeOnly)

The updated dependency-analysis analyzes type annotations much better.

The command to analyze dependencies is

    ./gradlew -PenableDependencyAnalysis buildHealth
@julianhyde
Copy link
Contributor

Please log a JIRA case for this.

@vlsi vlsi changed the title Refine dependency declarations to better account for type annotations [CALCITE-4618] Refine dependency declarations to better account for type annotations May 21, 2021
@asolimando
Copy link
Member

In the meantime, all the suspected false positives have been verified/fixed, so I think we are good to go now.

PS: I did not know the tool, I wish there was a similar tool for Maven too, "manual" dependency management is hard!

@vlsi
Copy link
Contributor Author

vlsi commented May 30, 2022

I'm not interested in moving this forward

@vlsi vlsi closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants