[CALCITE-528] Uniquification should be case aware if lex/catalog reader is case sensitive#245
Closed
minji-kim wants to merge 6 commits intoapache:masterfrom
Closed
[CALCITE-528] Uniquification should be case aware if lex/catalog reader is case sensitive#245minji-kim wants to merge 6 commits intoapache:masterfrom
minji-kim wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
|
We probably need the change in [1]. Otherwise, the output field names will not in the same ordinal position. Try field name list "EMPID, EMPID, abc". Uniqify() might return "abc, EMPID, EMPID0". |
Contributor
Author
|
@jinfengni Thanks for the patch. I grabbed it to my branch and added some more tests (specifically testing orders of the field names and making sure they are in the same order minus the name changes). |
Contributor
|
@minji-kim , sounds good. |
Our use of Jetty resulted in only the server's realm to be allowed for SPNEGO authentication. We should expose the configuration for downstream systems to set the allowed realms.
…ding to type system and catalog policies.
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jun 15, 2016
…se-sensitivity policy (Jacques Nadeau, Jinfeng Ni, Minji Kim) Ensure that uniquify keeps the ordinal position of input names (Jinfeng Ni). Add tests (Minji Kim). Fix up (Julian Hyde). Close apache#245
jinfengni
pushed a commit
to jinfengni/incubator-optiq
that referenced
this pull request
Jun 27, 2016
…se-sensitivity policy (Jacques Nadeau, Jinfeng Ni, Minji Kim) Ensure that uniquify keeps the ordinal position of input names (Jinfeng Ni). Add tests (Minji Kim). Fix up (Julian Hyde). Close apache#245 Apply change in checker.xml made in Calcite master (CALCITE-903)
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
…se-sensitivity policy (Jacques Nadeau, Jinfeng Ni, Minji Kim) Ensure that uniquify keeps the ordinal position of input names (Jinfeng Ni). Add tests (Minji Kim). Fix up (Julian Hyde). Close apache/calcite#245
pfzhan
pushed a commit
to pfzhan/calcite
that referenced
this pull request
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.