[CALCITE-1289] RexUtil.simplifyCase() should account for nullability#248
Closed
minji-kim wants to merge 4 commits intoapache:masterfrom
Closed
[CALCITE-1289] RexUtil.simplifyCase() should account for nullability#248minji-kim wants to merge 4 commits intoapache:masterfrom
minji-kim wants to merge 4 commits intoapache:masterfrom
Conversation
Our use of Jetty resulted in only the server's realm to be allowed for SPNEGO authentication. We should expose the configuration for downstream systems to set the allowed realms.
Contributor
|
Tests for RexUtil.simplify are currently in RexProgramTest. Can you add more tests there, rather than adding a new test. Please try to match the formatting. We indent arguments 4 spaces, not 8, and we tend to put @test on the same line. |
Contributor
Author
|
Thanks, @julianhyde! I moved the tests to RexProgramTest. I also changed my editor's setting, so the spacing issue shouldn't happen anymore. |
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#258) …… (apache#248) …lAs strategy (Jin Xing) Close apache#1605 Co-authored-by: jx158167 <jinxing.corey@gmail.com>
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#258) …… (apache#248) …lAs strategy (Jin Xing) Close apache#1605 Co-authored-by: jx158167 <jinxing.corey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.